Добавлен метод загрузки визитов веб-аналитики #184
Conversation
Artem9-9
force-pushed
the
webanalitics-upload-visits
branch
2 times, most recently
from
3c252c2
to
ccf6580
Compare
src/ResourceGroup/WebAnalytics.php
Outdated
| /** @var VisitsUploadResponse $response */ | ||
| $response = $this->sendRequest( | ||
| RequestMethod::POST, | ||
| 'web-analytics/client-ids/upload', |
There was a problem hiding this comment.
Должно быть '/web-analytics/visits/upload'.
There was a problem hiding this comment.
а почему тогда к примеру в clientIdsUpload без этого слеша?
There was a problem hiding this comment.
Да, слешь не нужно, копипаст сработал. А вот вместо client-ids должно быть visits.
| EOF; | ||
|
|
||
| $entity = new Visit(); | ||
| $entity->createdAt = '2023-12-06T12:00:00'; |
There was a problem hiding this comment.
У нас формат Y-m-d H:i:s заложен. Если использовать текущий, нужно править логику апишки.
There was a problem hiding this comment.
исправил, подогнал под нужный формат
| { | ||
| "success": true | ||
| } | ||
| EOF; |
There was a problem hiding this comment.
вообще да, но поправил на более привычный вид
$json = '{"success": true}';
| * @JMS\Type("string") | ||
| * @JMS\SerializedName("pageDepth") | ||
| */ | ||
| public $pageDepth; |
There was a problem hiding this comment.
У текущей и у $pageViews и $visitLength должны быть числовые типы.
src/ResourceGroup/WebAnalytics.php
Outdated
| * $client = SimpleClientFactory::createClient('https://test.retailcrm.pro', 'apiKey'); | ||
| * | ||
| * $entity = new Visit(); | ||
| * $entity->createdAt = '2023-12-06T12:00:00'; |
There was a problem hiding this comment.
Тут также формат другой, у нас Y-m-d H:i:s.
| ->withBody($json); | ||
|
|
||
| $client = TestClientFactory::createClient($mock->getClient()); | ||
| $response = $client->webAnalytics->visitsUpload($request); |
Artem9-9
force-pushed
the
webanalitics-upload-visits
branch
from
ccf6580
to
118ef18
Compare
| * @JMS\Type("int") | ||
| * @JMS\SerializedName("pageViews") | ||
| */ | ||
| public $pageViews; |
There was a problem hiding this comment.
У нас мы меняли это название на countViews. В аннотации тоже нужно поменять.
| /** | ||
| * @var int | ||
| * | ||
| * @JMS\Type("int") |
There was a problem hiding this comment.
Тут тоже для единообразия integer можно.
| * @JMS\Type("string") | ||
| * @JMS\SerializedName("pageDepth") | ||
| */ | ||
| public $pageDepth; |
Artem9-9
force-pushed
the
webanalitics-upload-visits
branch
from
118ef18
to
2d0ed4c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
============================================
+ Coverage 84.26% 84.30% +0.04%
- Complexity 1105 1108 +3
============================================
Files 168 169 +1
Lines 4194 4205 +11
============================================
+ Hits 3534 3545 +11
Misses 660 660 ☔ View full report in Codecov by Sentry. |
No description provided.